kaijchen commented on code in PR #478:
URL: https://github.com/apache/incubator-uniffle/pull/478#discussion_r1069576310
##########
storage/src/test/java/org/apache/uniffle/storage/handler/impl/LocalFileHandlerTestBase.java:
##########
@@ -44,16 +44,13 @@
public class LocalFileHandlerTestBase {
private static AtomicLong ATOMIC_LONG = new AtomicLong(0L);
- public static void reset() {
- ATOMIC_LONG = new AtomicLong(0L);
- }
-
- public static void writeTestData(
+ public static List<Long> writeTestData(
ShuffleWriteHandler writeHandler,
int num, int length,
Map<Long, byte[]> expectedData,
Set<Long> expectedBlockIds) throws Exception {
List<ShufflePartitionedBlock> blocks = Lists.newArrayList();
+ List<Long> blockIds = Lists.newArrayList();
Review Comment:
Can you give an example how to use `expectedBlockIds` in `calcSegmentBytes`?
I think we should preserve order and exclude the last block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
