zuston commented on code in PR #494:
URL: https://github.com/apache/incubator-uniffle/pull/494#discussion_r1072224949
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -322,16 +322,22 @@ public void updateCachedBlockIds(String appId, int
shuffleId, int partitionId, S
size += spb.getSize();
}
}
- shuffleTaskInfo.addPartitionDataSize(
+ long partitionSize = shuffleTaskInfo.addPartitionDataSize(
shuffleId,
partitionId,
size
);
+ if (shuffleBufferManager.isHugePartition(partitionSize)) {
Review Comment:
> I think this's the better place to update related metrics here.
Sounds good. Let me take a look tomorrow
> Once shuffleBufferManager detects a huge partition, it cloud increase the
app_num_with_huge_partition metrics if the appId is not already added to
hasSeenAppIdSet.
Actually I don’t hope we maintain the
hasSeenAppIdSet data structure in shuffleBufferManager. This info bound to
shuffleTaskInfo will be better ? WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
