zuston commented on code in PR #494:
URL: https://github.com/apache/incubator-uniffle/pull/494#discussion_r1073244154
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -322,16 +322,22 @@ public void updateCachedBlockIds(String appId, int
shuffleId, int partitionId, S
size += spb.getSize();
}
}
- shuffleTaskInfo.addPartitionDataSize(
+ long partitionSize = shuffleTaskInfo.addPartitionDataSize(
shuffleId,
partitionId,
size
);
+ if (shuffleBufferManager.isHugePartition(partitionSize)) {
Review Comment:
> One appId could had multiple shuffleTaskInfos, right?
One appId only has one shuffleTaskInfo.
> Once shuffleBufferManager detects a huge partition, it cloud increase the
app_num_with_huge_partition metrics if the appId is not already added to
hasSeenAppIdSet.
How to maintain `hasSeenAppIdSet`'s lifecycle? Should one element of one
appId in `hasSeenAppIdSet` keep consistent with its `shuffleTaskInfo`
lifecycle? If yes, it also will be removed due to heartbeat timeout. Otherwise,
we have to maintain `hasSeenAppIdSet` lifecycle independently, this is too
complex and unreasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
