xianjingfeng commented on code in PR #510:
URL: https://github.com/apache/incubator-uniffle/pull/510#discussion_r1089899642
##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -145,6 +134,31 @@ public void addToFlushQueue(ShuffleDataFlushEvent event) {
}
}
+ public void processEvents(boolean endless) {
Review Comment:
I mean `flushQueue.take()` will block the thread until `flushQueue` is not
empty and it will not cost too much cpu resources. But `flushQueue.take()` will
not block the thread in the code you implement and it will not cost a lot of
cpu resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
