kaijchen commented on code in PR #510:
URL: https://github.com/apache/incubator-uniffle/pull/510#discussion_r1089907950
##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -145,6 +134,31 @@ public void addToFlushQueue(ShuffleDataFlushEvent event) {
}
}
+ public void processEvents(boolean endless) {
Review Comment:
Update:
Actually I'm splitting `processEvents()` into `eventLoop()` and `flush()`.
```java
protected void eventLoop() {
while (true) {
processNextEvent();
}
}
@VisibleForTesting
public void flush() {
while (!flushQueue.isEmpty()) {
processNextEvent();
}
}
private void processNextEvent() {
try {
ShuffleDataFlushEvent event = flushQueue.take();
threadPoolExecutor.execute(() -> {
processEvent(event);
});
} catch (Exception e) {
LOG.error("Exception happened when process event.", e);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
