advancedxy commented on code in PR #491:
URL: https://github.com/apache/incubator-uniffle/pull/491#discussion_r1089940447
##########
deploy/kubernetes/operator/Makefile:
##########
@@ -16,12 +16,16 @@
#
# REGISTRY URL to use all building/pushing image targets
-REGISTRY ?= UNKNOWN_REGISTRY
+REGISTRY ?= ''
+
+ifneq ('', ${REGISTRY})
+REGISTRY := $(addsuffix /, ${REGISTRY})
+endif
MODULES ?= webhook controller
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be
downloaded by envtest binary.
-ENVTEST_K8S_VERSION = 1.22.1
+ENVTEST_K8S_VERSION = 1.24.1
Review Comment:
> As discussed earlier, why upgrade envtest to 1.24 when you don't need to
upgrade k8s to 1.24? cc @advancedxy
Yeah, as discussed earlier. Envtest is upgraded to 1.24 to support Apple
M1's chips as 1.22 doesn't work for M1 chip.
The operator itself doesn't need to upgrade to 1.24 and it shouldn't since
many K8S clusters are in old versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
