kaijchen commented on code in PR #491:
URL: https://github.com/apache/incubator-uniffle/pull/491#discussion_r1089916690
##########
deploy/kubernetes/operator/hack/Dockerfile:
##########
@@ -35,12 +35,9 @@ COPY pkg/ pkg/
# Build
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o
${MODULE} cmd/${MODULE}/main.go
-# Use distroless as minimal base image to package the manager binary
-# Refer to https://github.com/GoogleContainerTools/distroless for more details
-FROM alpine
-RUN apk add --update curl && \
- rm -rf /var/cache/apk/*
+FROM debian:11.6-slim
+ARG MODULE
Review Comment:
Yes this looks good, ref:
https://docs.docker.com/engine/reference/builder/#scope
Maybe add some empty lines or comments between two build stages, so it will
be more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
