advancedxy commented on code in PR #517:
URL: https://github.com/apache/incubator-uniffle/pull/517#discussion_r1090131165
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/PooledHdfsShuffleWriteHandler.java:
##########
@@ -67,6 +67,7 @@ public PooledHdfsShuffleWriteHandler(
user
)
);
+ assert success;
Review Comment:
assert should never be used in prod as assertion might be turned off.
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/PooledHdfsShuffleWriteHandler.java:
##########
@@ -55,7 +55,7 @@ public PooledHdfsShuffleWriteHandler(
// todo: support init lazily
try {
for (int i = 0; i < maxConcurrency; i++) {
- queue.offer(
Review Comment:
this code seems a bit strange... Could we add some comment macro to disable
this check?
##########
spotbugs-exclude.xml:
##########
@@ -19,4 +19,7 @@
<Match>
<Package name="~org\.apache\.uniffle\.proto.*"/>
</Match>
+ <Match>
+ <Bug
pattern="MS_EXPOSE_REP,EI_EXPOSE_REP,EI_EXPOSE_REP2,EI_EXPOSE_STATIC_REP2,THROWS_METHOD_THROWS_RUNTIMEEXCEPTION,THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION,REC_CATCH_EXCEPTION,THROWS_METHOD_THROWS_CLAUSE_THROWABLE,MS_PKGPROTECT,MS_CANNOT_BE_FINAL,UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD,SE_BAD_FIELD,URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD,SC_START_IN_CTOR,SWL_SLEEP_WITH_LOCK_HELD,IS2_INCONSISTENT_SYNC"
/>
Review Comment:
is it possible to reduce the pattern here by refactoring some code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
