advancedxy commented on code in PR #517:
URL: https://github.com/apache/incubator-uniffle/pull/517#discussion_r1090151860
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/PooledHdfsShuffleWriteHandler.java:
##########
@@ -55,7 +55,7 @@ public PooledHdfsShuffleWriteHandler(
// todo: support init lazily
try {
for (int i = 0; i < maxConcurrency; i++) {
- queue.offer(
+ queue.add(
Review Comment:
add a comment before line58 then?
You can simply use the wording here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
