kaijchen commented on code in PR #470:
URL: https://github.com/apache/incubator-uniffle/pull/470#discussion_r1090268671
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -192,12 +206,28 @@ private boolean sendShuffleDataAsync(
return result;
}
- private void genServerToBlocks(ShuffleBlockInfo sbi, List<ShuffleServerInfo>
serverList,
+ void genServerToBlocks(
+ ShuffleBlockInfo sbi,
+ List<ShuffleServerInfo> serverList,
+ int replicaNum,
+ List<ShuffleServerInfo> excludeServers,
Map<ShuffleServerInfo, Map<Integer, Map<Integer,
List<ShuffleBlockInfo>>>> serverToBlocks,
- Map<ShuffleServerInfo, List<Long>> serverToBlockIds) {
+ Map<ShuffleServerInfo, List<Long>> serverToBlockIds,
+ boolean withoutBlocklist) {
+ if (replicaNum <= 0) {
+ return;
+ }
int partitionId = sbi.getPartitionId();
int shuffleId = sbi.getShuffleId();
+ int assignedNum = 0;
for (ShuffleServerInfo ssi : serverList) {
+ if (withoutBlocklist && replica > 1
+ && shuffleServerBlocklist.contains(ssi)) {
Review Comment:
This condition looks strange to me: `withoutBlocklist &&
shuffleServerBlocklist.contains(ssi)`.
Could you explain what `withoutBlocklist` is controlling here?
Maybe the name of this parameter still needs to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
