jerqi commented on code in PR #470:
URL: https://github.com/apache/incubator-uniffle/pull/470#discussion_r1090501134
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -216,6 +246,18 @@ private void genServerToBlocks(ShuffleBlockInfo sbi,
List<ShuffleServerInfo> ser
partitionToBlocks.put(partitionId, Lists.newArrayList());
}
partitionToBlocks.get(partitionId).add(sbi);
+ if (excludeServers != null) {
+ excludeServers.add(ssi);
+ }
+ assignedNum++;
+ if (assignedNum >= replicaNum) {
+ break;
+ }
+ }
+
+ if (assignedNum < replicaNum && withBlocklist) {
+ genServerToBlocks(sbi, serverList, replicaNum - assignedNum,
Review Comment:
Do this cause that one shuffle server will allocate twice?
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -216,6 +246,18 @@ private void genServerToBlocks(ShuffleBlockInfo sbi,
List<ShuffleServerInfo> ser
partitionToBlocks.put(partitionId, Lists.newArrayList());
}
partitionToBlocks.get(partitionId).add(sbi);
+ if (excludeServers != null) {
+ excludeServers.add(ssi);
+ }
+ assignedNum++;
+ if (assignedNum >= replicaNum) {
+ break;
+ }
+ }
+
+ if (assignedNum < replicaNum && withBlocklist) {
+ genServerToBlocks(sbi, serverList, replicaNum - assignedNum,
Review Comment:
Do this cause that one shuffle server will be allocated twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
