advancedxy commented on code in PR #527:
URL: https://github.com/apache/incubator-uniffle/pull/527#discussion_r1091887844
##########
client-mr/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -366,7 +366,10 @@ static void writeExtraConf(JobConf conf, JobConf
extraConf) {
long size = status.getLen();
String sizes = conf.get(MRJobConfig.CACHE_FILES_SIZES);
conf.set(MRJobConfig.CACHE_FILES_SIZES, sizes == null ?
String.valueOf(size) : size + "," + sizes);
- } catch (Exception e) {
+ } catch (InterruptedException e) {
+ LOG.error("Interrupted while trying to upload extra conf ", e);
+ Thread.currentThread().interrupt();
Review Comment:
Still no.
For this method, an interrupt exception means this method doesn't complete
succeeded. The caller method should abort rather than continues executing.
You either to propagate this InterruptedException or wrapped it into another
runtime exception,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
