kaijchen commented on code in PR #527:
URL: https://github.com/apache/incubator-uniffle/pull/527#discussion_r1091955123
##########
client-mr/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -366,7 +366,10 @@ static void writeExtraConf(JobConf conf, JobConf
extraConf) {
long size = status.getLen();
String sizes = conf.get(MRJobConfig.CACHE_FILES_SIZES);
conf.set(MRJobConfig.CACHE_FILES_SIZES, sizes == null ?
String.valueOf(size) : size + "," + sizes);
- } catch (Exception e) {
+ } catch (InterruptedException e) {
+ LOG.error("Interrupted while trying to upload extra conf ", e);
+ Thread.currentThread().interrupt();
Review Comment:
> By now it should be clear that just doing throw new RuntimeException(e) is
a bad idea. It isn't very polite to the caller. You could invent a new runtime
exception but the root cause (someone wants the thread to stop execution) might
get lost.
Quoted from the link above, it's a bad idea to throw new RuntimeException(e).
And we cannot propagate InterruptedException here because `RssMRAppMaster`
extends `org.apache.hadoop.mapreduce.v2.app.MRAppMaster`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
