wangao1236 commented on code in PR #531:
URL: https://github.com/apache/incubator-uniffle/pull/531#discussion_r1092813634
##########
deploy/kubernetes/operator/pkg/webhook/inspector/rss.go:
##########
@@ -35,19 +35,19 @@ import (
// validateRSS validates the create and update operation towards rss objects.
func (i *inspector) validateRSS(ar *admissionv1.AdmissionReview)
*admissionv1.AdmissionReview {
if !i.ignoreRSS && ar.Request.Operation == admissionv1.Update {
- oldRSS := &unifflev1alpha1.RemoteShuffleService{}
+ oldRSS := &uniffleAPI.RemoteShuffleService{}
if err := json.Unmarshal(ar.Request.OldObject.Raw, oldRSS); err
!= nil {
klog.Errorf("unmarshal old object of rss (%v) failed:
%v",
string(ar.Request.OldObject.Raw), err)
return util.AdmissionReviewFailed(ar, err)
}
- // for security purposes, we forbid updating rss objects when
they are in upgrading phase.
- if oldRSS.Status.Phase == unifflev1alpha1.RSSUpgrading {
- message := "can not update upgrading rss object: " +
utils.UniqueName(oldRSS)
+ // for security purposes, we forbid updating rss objects when
they are in upgrading/terminating phase.
+ if oldRSS.Status.Phase == uniffleAPI.RSSUpgrading ||
oldRSS.Status.Phase == uniffleAPI.RSSTerminating {
Review Comment:
The only protection mechanism is finalizer. This is not automatically added
by the k8s, but by the controller. Controller needs to add and remove
finalizers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
