advancedxy commented on code in PR #531:
URL: https://github.com/apache/incubator-uniffle/pull/531#discussion_r1092831683
##########
deploy/kubernetes/operator/pkg/webhook/inspector/rss.go:
##########
@@ -35,19 +35,19 @@ import (
// validateRSS validates the create and update operation towards rss objects.
func (i *inspector) validateRSS(ar *admissionv1.AdmissionReview)
*admissionv1.AdmissionReview {
if !i.ignoreRSS && ar.Request.Operation == admissionv1.Update {
- oldRSS := &unifflev1alpha1.RemoteShuffleService{}
+ oldRSS := &uniffleAPI.RemoteShuffleService{}
if err := json.Unmarshal(ar.Request.OldObject.Raw, oldRSS); err
!= nil {
klog.Errorf("unmarshal old object of rss (%v) failed:
%v",
string(ar.Request.OldObject.Raw), err)
return util.AdmissionReviewFailed(ar, err)
}
- // for security purposes, we forbid updating rss objects when
they are in upgrading phase.
- if oldRSS.Status.Phase == unifflev1alpha1.RSSUpgrading {
- message := "can not update upgrading rss object: " +
utils.UniqueName(oldRSS)
+ // for security purposes, we forbid updating rss objects when
they are in upgrading/terminating phase.
+ if oldRSS.Status.Phase == uniffleAPI.RSSUpgrading ||
oldRSS.Status.Phase == uniffleAPI.RSSTerminating {
Review Comment:
discussed offline, current code doesn't handle deny update during
terminating correct. The finalizers should be removed(update) by the
controller. It will bring some complex logic to do it correctly.
However there's no need to deny update when terminating as the rss
controller doesn't refer any other fields rather than
finalizer/deletionTimestamp when terminating.
Conclusion: revert changes in webhook side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
