jerqi commented on code in PR #811:
URL: https://github.com/apache/incubator-uniffle/pull/811#discussion_r1166508931
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java:
##########
@@ -76,7 +77,7 @@ public class WriteBufferManager extends MemoryConsumer {
private Map<Integer, List<ShuffleServerInfo>> partitionToServers;
private int serializerBufferSize;
private int bufferSegmentSize;
- private long copyTime = 0;
+ private volatile long copyTime = 0;
Review Comment:
If the operation of `copyTime` will be operated in the scope of lock, they
don't nee `volatile`, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
