zuston commented on PR #811: URL: https://github.com/apache/incubator-uniffle/pull/811#issuecomment-1514587162
After rethinking, I think the spill should not block when acquiring the lock, because the addRecord can take a long time, especially for tight memory. So in the latest commit. I use the `ReentrantLock#tryLock` to avoid this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
