advancedxy commented on code in PR #950:
URL: https://github.com/apache/incubator-uniffle/pull/950#discussion_r1230473728
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java:
##########
@@ -141,7 +140,11 @@ public WriteBufferManager(
this.requireMemoryInterval =
bufferManagerOptions.getRequireMemoryInterval();
this.requireMemoryRetryMax =
bufferManagerOptions.getRequireMemoryRetryMax();
this.arrayOutputStream = new
WrappedByteArrayOutputStream(serializerBufferSize);
- this.serializeStream = instance.serializeStream(arrayOutputStream);
+ // columnar shuffle use the serialized data directly
+ if (serializer != null) {
Review Comment:
I see.
would you mind to update the JavaDoc of `addPartitionData` to reflect this
info.
And update the comment of L143 to indicate serializer might never be used
when integrating with gluten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
