summaryzb commented on PR #950: URL: https://github.com/apache/incubator-uniffle/pull/950#issuecomment-1594266298
> Is it possible that UniffleShuffleManager extends RssShuffleManager and UniffleColumnarShuffleWriter extends RssShuffleWriter? That's really good idea, it'll make the gluten side code more simplify. How about refactor that in next patch, since many fields type need to be changed to protected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
