qijiale76 commented on code in PR #1112:
URL:
https://github.com/apache/incubator-uniffle/pull/1112#discussion_r1285725496
##########
client-mr/core/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -153,9 +141,13 @@ public Thread newThread(Runnable r) {
}
});
- JobConf extraConf = new JobConf();
+ // set loadDefaults to false, rss_conf.xml should only contain conf of
RSS,
+ // Hadoop conf is not necessary.
+ Configuration extraConf = new JobConf(false);
extraConf.clear();
+ RssMRUtils.applyClientConf(extraConf, conf);
Review Comment:
add `mapreduce.rss.*` properties to `rss_conf.xml`
##########
client-mr/core/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -153,9 +141,13 @@ public Thread newThread(Runnable r) {
}
});
- JobConf extraConf = new JobConf();
+ // set loadDefaults to false, rss_conf.xml should only contain conf of
RSS,
+ // Hadoop conf is not necessary.
+ Configuration extraConf = new JobConf(false);
Review Comment:
set `loadDefaults` to false, make `rss_conf.xml` has only `mapreduce.rss.*`
properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
