qijiale76 commented on code in PR #1112:
URL:
https://github.com/apache/incubator-uniffle/pull/1112#discussion_r1285730053
##########
client-mr/core/src/main/java/org/apache/hadoop/mapreduce/RssMRUtils.java:
##########
@@ -283,23 +317,20 @@ public static int getRequiredShuffleServerNumber(JobConf
jobConf) {
return (int) Math.ceil(taskConcurrency * 1.0 / taskConcurrencyPerServer);
}
- public static void validateRssClientConf(JobConf rssJobConf, JobConf
mrJobConf) {
+ public static void validateRssClientConf(Configuration rssJobConf) {
int retryMax =
getInt(
rssJobConf,
- mrJobConf,
RssMRConfig.RSS_CLIENT_RETRY_MAX,
RssMRConfig.RSS_CLIENT_RETRY_MAX_DEFAULT_VALUE);
long retryIntervalMax =
getLong(
rssJobConf,
- mrJobConf,
RssMRConfig.RSS_CLIENT_RETRY_INTERVAL_MAX,
RssMRConfig.RSS_CLIENT_RETRY_INTERVAL_MAX_DEFAULT_VALUE);
long sendCheckTimeout =
getLong(
rssJobConf,
- mrJobConf,
RssMRConfig.RSS_CLIENT_SEND_CHECK_TIMEOUT_MS,
Review Comment:
all unnecessary `mrJobConf` is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
