zhengchenyu commented on code in PR #1122:
URL: 
https://github.com/apache/incubator-uniffle/pull/1122#discussion_r1289521114


##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -649,6 +649,7 @@ public void checkLeakShuffleData() {
   public void removeResources(String appId) {
     LOG.info("Start remove resource for appId[" + appId + "]");
     final long start = System.currentTimeMillis();
+    String user = getUserByAppId(appId);

Review Comment:
   Only the next line code will remove shuffleTaskInfos. I move before it. 
   Because after next line, getUserByAppId(appId) is always null. 
   User name is not a problem for non security cluster. But user name is 
important for security cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to