zhengchenyu commented on code in PR #1122:
URL:
https://github.com/apache/incubator-uniffle/pull/1122#discussion_r1289708191
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -649,6 +649,7 @@ public void checkLeakShuffleData() {
public void removeResources(String appId) {
LOG.info("Start remove resource for appId[" + appId + "]");
final long start = System.currentTimeMillis();
+ String user = getUserByAppId(appId);
Review Comment:
> `user` may be null some times If app is removed.
@jerqi
Only next line will remove app from shuffleTaskInfo.
Here I move getUserByAppId before 'shuffleTaskInfos.remove(appId)', or user
will be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
