zuston commented on code in PR #1265:
URL:
https://github.com/apache/incubator-uniffle/pull/1265#discussion_r1374181999
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -304,56 +306,54 @@ protected List<CompletableFuture<Long>> postBlockEvent(
LOG.error("Add event " + event + " to finishEventQueue fail");
}
});
- futures.add(shuffleManager.sendData(event));
+ CompletableFuture<Long> longCompletableFuture =
shuffleManager.sendData(event);
Review Comment:
rename to `outstandingDataSentFuture` ?
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -442,6 +442,8 @@ public Option<MapStatus> stop(boolean success) {
return Option.empty();
}
} finally {
+ // cancel all async thread task related
+ sendingSet.stream().forEach(eventTask -> eventTask.cancel(true));
Review Comment:
If the task held by this future is still in the queue of dataPusher, the
cancel operation will not be valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
