summaryzb commented on code in PR #1265:
URL:
https://github.com/apache/incubator-uniffle/pull/1265#discussion_r1374360523
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -442,6 +442,8 @@ public Option<MapStatus> stop(boolean success) {
return Option.empty();
}
} finally {
+ // cancel all async thread task related
+ sendingSet.stream().forEach(eventTask -> eventTask.cancel(true));
Review Comment:
> And if the task is running of pushing data to shuffle server, the
interrupt signal caused by the operation of `future.cancel` will be accepted
and then exit quickly, right?
In fact, the signal will not be passed to the executing thread, i'll change
the `CompletableFuture` to ` FutureTask`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
