zuston commented on code in PR #1412:
URL:
https://github.com/apache/incubator-uniffle/pull/1412#discussion_r1441201246
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -69,6 +69,10 @@ public class ShuffleServerMetrics {
private static final String IS_HEALTHY = "is_healthy";
private static final String ALLOCATED_BUFFER_SIZE = "allocated_buffer_size";
+ private static final String EXPIRED_PRE_ALLOCATED_BUFFER_SIZE =
Review Comment:
these metrics should be counter rather than gauge. Right ?
And the name should be obey the rule. xxxx_total
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
