zhengchenyu commented on code in PR #1412:
URL:
https://github.com/apache/incubator-uniffle/pull/1412#discussion_r1441382035
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -766,17 +766,21 @@ private void preAllocatedBufferCheck() {
removeIds.add(info.getRequireId());
}
}
+ int expiredBufferIdsCnt = 0;
for (Long requireId : removeIds) {
PreAllocatedBufferInfo info = requireBufferIds.remove(requireId);
if (info != null) {
// move release memory code down to here as the requiredBuffer could
be consumed during
// removing processing.
shuffleBufferManager.releaseMemory(info.getRequireSize(), false,
true);
+
ShuffleServerMetrics.counterExpiredPreAllocatedBufferSizeTotal.inc(info.getRequireSize());
Review Comment:
CounterExpiredPreAllocatedBufferSizeTotal is necessary? I feel A bit
repetitive with counterExpiredPreAllocatedBufferIdTotal.
If we're just trying to capture how often timeouts happen,
counterExpiredPreAllocatedBufferIdTotal maybe enough. But I'm not sure if you
serve any other purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
