lifeSo commented on code in PR #1400:
URL:
https://github.com/apache/incubator-uniffle/pull/1400#discussion_r1442850430
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -345,5 +358,33 @@ private static void setUpMetrics() {
summaryTotalRemoveResourceTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_TIME);
summaryTotalRemoveResourceByShuffleIdsTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_BY_SHUFFLE_IDS_TIME);
+
+ gaugeDataSizeTotalUsage =
+ Gauge.build()
+ .name(TOPN_OF_TOTAL_DATA_SIZE_FOR_APP)
+ .help("top N of total shuffle data size for app level")
+ .labelNames("topn_of_total_data_size_for_app")
Review Comment:
Or How about code:
```
Gauge.build()
.name(TOPN_OF_TOTAL_DATA_SIZE_FOR_APP)
.help("top N of total shuffle data size for app level")
.labelNames("")
```
labelNames is set to "".
Sorry, I tried this, and get error when run the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
