zuston commented on code in PR #1400:
URL:
https://github.com/apache/incubator-uniffle/pull/1400#discussion_r1449709142
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -345,5 +358,33 @@ private static void setUpMetrics() {
summaryTotalRemoveResourceTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_TIME);
summaryTotalRemoveResourceByShuffleIdsTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_BY_SHUFFLE_IDS_TIME);
+
+ gaugeTotalDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_TOTAL_DATA_SIZE_FOR_APP)
+ .help("top N of total shuffle data size for app level")
+ .labelNames("TOPN_OF_TOTAL_DATA_SIZE_FOR_APP")
+ .register(metricsManager.getCollectorRegistry());
+
+ gaugeInMemoryDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_IN_MEMORY_DATA_SIZE_FOR_APP)
+ .help("top N of in memory shuffle data size for app level")
+ .labelNames("TOPN_OF_IN_MEMORY_DATA_SIZE_FOR_APP")
Review Comment:
ditto
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -345,5 +358,33 @@ private static void setUpMetrics() {
summaryTotalRemoveResourceTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_TIME);
summaryTotalRemoveResourceByShuffleIdsTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_BY_SHUFFLE_IDS_TIME);
+
+ gaugeTotalDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_TOTAL_DATA_SIZE_FOR_APP)
+ .help("top N of total shuffle data size for app level")
+ .labelNames("TOPN_OF_TOTAL_DATA_SIZE_FOR_APP")
+ .register(metricsManager.getCollectorRegistry());
+
+ gaugeInMemoryDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_IN_MEMORY_DATA_SIZE_FOR_APP)
+ .help("top N of in memory shuffle data size for app level")
+ .labelNames("TOPN_OF_IN_MEMORY_DATA_SIZE_FOR_APP")
+ .register(metricsManager.getCollectorRegistry());
+
+ gaugeOnDiskDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_ON_LOCALFILE_DATA_SIZE_FOR_APP)
+ .help("top N of on disk shuffle data size for app level")
+ .labelNames("TOPN_OF_ON_LOCALFILE_DATA_SIZE_FOR_APP")
+ .register(metricsManager.getCollectorRegistry());
+
+ gaugeOnHadoopDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_ON_HADOOP_DATA_SIZE_FOR_APP)
+ .help("top N of on hadoop shuffle data size for app level")
+ .labelNames("TOPN_OF_ON_HADOOP_DATA_SIZE_FOR_APP")
Review Comment:
ditto
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -345,5 +358,33 @@ private static void setUpMetrics() {
summaryTotalRemoveResourceTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_TIME);
summaryTotalRemoveResourceByShuffleIdsTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_BY_SHUFFLE_IDS_TIME);
+
+ gaugeTotalDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_TOTAL_DATA_SIZE_FOR_APP)
+ .help("top N of total shuffle data size for app level")
+ .labelNames("TOPN_OF_TOTAL_DATA_SIZE_FOR_APP")
+ .register(metricsManager.getCollectorRegistry());
+
+ gaugeInMemoryDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_IN_MEMORY_DATA_SIZE_FOR_APP)
+ .help("top N of in memory shuffle data size for app level")
+ .labelNames("TOPN_OF_IN_MEMORY_DATA_SIZE_FOR_APP")
+ .register(metricsManager.getCollectorRegistry());
+
+ gaugeOnDiskDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_ON_LOCALFILE_DATA_SIZE_FOR_APP)
+ .help("top N of on disk shuffle data size for app level")
+ .labelNames("TOPN_OF_ON_LOCALFILE_DATA_SIZE_FOR_APP")
Review Comment:
ditto
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -345,5 +358,33 @@ private static void setUpMetrics() {
summaryTotalRemoveResourceTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_TIME);
summaryTotalRemoveResourceByShuffleIdsTime =
metricsManager.addSummary(TOTAL_REMOVE_RESOURCE_BY_SHUFFLE_IDS_TIME);
+
+ gaugeTotalDataSizeUsage =
+ Gauge.build()
+ .name(TOPN_OF_TOTAL_DATA_SIZE_FOR_APP)
+ .help("top N of total shuffle data size for app level")
+ .labelNames("TOPN_OF_TOTAL_DATA_SIZE_FOR_APP")
Review Comment:
rename to `app_id`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
