EnricoMi commented on PR #1529: URL: https://github.com/apache/incubator-uniffle/pull/1529#issuecomment-1947835597
Re https://github.com/apache/incubator-uniffle/pull/1514#issuecomment-1947695463: > #1529 looks fine, can we add a integration test to cover the case of speculative exection? The added `FailingTasksTest` simulates speculative execution quite well because the failing tasks actually write shuffle data but do not register the shuffle result, so they represent the killed slow tasks. The succeeding attempts represent the speculative task. A speculative execution setup requires workers / executors with different host names. I think that has not been done in Uniffle before, so that would require some significant work with little extra benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
