zuston commented on PR #1529: URL: https://github.com/apache/incubator-uniffle/pull/1529#issuecomment-1948127220
> The added `FailingTasksTest` simulates speculative execution quite well because the failing tasks actually write shuffle data but do not register the shuffle result, so they represent the killed slow tasks. The succeeding attempts represent the speculative task. Make sense. > Further, a `TASK_ATTEMPT_ID_MAX_LENGTH` that is smaller than `PARTITION_ID_MAX_LENGTH` does not make sense. A single stage with 2^`PARTITION_ID_MAX_LENGTH` partitions would create at least as many task attempt ids, which immediately exhausts `TASK_ATTEMPT_ID_MAX_LENGTH`. So there is room for improvement. Thanks for your explanation, make sense for me. cc @jerqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
