rickyma commented on code in PR #1455:
URL:
https://github.com/apache/incubator-uniffle/pull/1455#discussion_r1452889181
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleReadClientImpl.java:
##########
@@ -293,6 +293,9 @@ public void checkProcessedBlockIds() {
@Override
public void close() {
+ if (sdr != null) {
Review Comment:
~~I think this will not cause any side effects, and it will be more
readable? I can revert this if you want.~~
After my stress test, I found that we need this to avoid potential memory
leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
