rickyma commented on code in PR #1534:
URL:
https://github.com/apache/incubator-uniffle/pull/1534#discussion_r1500169283
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -80,11 +84,16 @@ public class ShuffleBufferManager {
protected Map<String, Map<Integer, AtomicLong>> shuffleSizeMap =
JavaUtils.newConcurrentMap();
public ShuffleBufferManager(ShuffleServerConf conf, ShuffleFlushManager
shuffleFlushManager) {
+ this.nettyServerEnabled = conf.get(ShuffleServerConf.RPC_SERVER_TYPE) ==
ServerType.GRPC_NETTY;
Review Comment:
I'll fix this in the next PR which will fix
https://github.com/apache/incubator-uniffle/pull/1008 together(mentioned in
https://github.com/apache/incubator-uniffle/pull/1531). If I change this in the
current PR, plenty of UTs will be failed. @zuston
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -80,11 +84,16 @@ public class ShuffleBufferManager {
protected Map<String, Map<Integer, AtomicLong>> shuffleSizeMap =
JavaUtils.newConcurrentMap();
public ShuffleBufferManager(ShuffleServerConf conf, ShuffleFlushManager
shuffleFlushManager) {
+ this.nettyServerEnabled = conf.get(ShuffleServerConf.RPC_SERVER_TYPE) ==
ServerType.GRPC_NETTY;
Review Comment:
I know this. I'll fix this in the next PR which will fix
https://github.com/apache/incubator-uniffle/pull/1008 together(mentioned in
https://github.com/apache/incubator-uniffle/pull/1531). If I change this in the
current PR, plenty of UTs will be failed. @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
