rickyma commented on code in PR #1534:
URL:
https://github.com/apache/incubator-uniffle/pull/1534#discussion_r1501625720
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -80,11 +84,16 @@ public class ShuffleBufferManager {
protected Map<String, Map<Integer, AtomicLong>> shuffleSizeMap =
JavaUtils.newConcurrentMap();
public ShuffleBufferManager(ShuffleServerConf conf, ShuffleFlushManager
shuffleFlushManager) {
+ this.nettyServerEnabled = conf.get(ShuffleServerConf.RPC_SERVER_TYPE) ==
ServerType.GRPC_NETTY;
Review Comment:
> The single source principle should be ensured. And the checking logic is
not same, you can see the current code in shuffleServer.java
>
> ```
> nettyServerEnabled =
shuffleServerConf.get(ShuffleServerConf.NETTY_SERVER_PORT) >= 0;
> if (nettyServerEnabled) {
> streamServer = new StreamServer(this);
> }
> ```
Done in https://github.com/apache/incubator-uniffle/pull/1540.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
