rickyma commented on code in PR #1611:
URL:
https://github.com/apache/incubator-uniffle/pull/1611#discussion_r1546145683
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -424,35 +422,38 @@ private void releaseFlushMemory(long size) {
ShuffleServerMetrics.gaugeInFlushBufferSize.set(inFlushSize.get());
}
- public boolean requireReadMemoryWithRetry(long size) {
+ public boolean requireReadMemory(long size) {
ShuffleServerMetrics.counterTotalRequireReadMemoryNum.inc();
- for (int i = 0; i < retryNum; i++) {
- synchronized (this) {
- if (readDataMemory.get() + size < readCapacity) {
- readDataMemory.addAndGet(size);
+ boolean success = false;
+
+ do {
+ long currentReadDataMemory = readDataMemory.get();
+ long newReadDataMemory = currentReadDataMemory + size;
+ if (newReadDataMemory < readCapacity) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
