zuston commented on code in PR #1611:
URL:
https://github.com/apache/incubator-uniffle/pull/1611#discussion_r1546156717
##########
internal-client/src/main/java/org/apache/uniffle/client/request/RssGetInMemoryShuffleDataRequest.java:
##########
@@ -65,4 +83,19 @@ public int getReadBufferSize() {
public Roaring64NavigableMap getExpectedTaskIds() {
return expectedTaskIds;
}
+
+ @Override
Review Comment:
The reason of make RetryRequest as an abstract class is to extra the
following retryMax params and so on into the RetryRequest class, rather than
scattering everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
