rickyma commented on code in PR #1616:
URL:
https://github.com/apache/incubator-uniffle/pull/1616#discussion_r1548842275
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcNettyClient.java:
##########
@@ -320,25 +341,35 @@ public RssGetShuffleDataResponse
getShuffleData(RssGetShuffleDataRequest request
+ "], partitionId["
+ request.getPartitionId()
+ "]";
- LOG.info(
- "GetShuffleData from {}:{} for {} cost {} ms",
- host,
- port,
- requestInfo,
- System.currentTimeMillis() - start);
- GetLocalShuffleDataResponse getLocalShuffleDataResponse =
- (GetLocalShuffleDataResponse) rpcResponse;
- StatusCode statusCode = rpcResponse.getStatusCode();
- switch (statusCode) {
+ long start = System.currentTimeMillis();
+ int retry = 0;
+ RpcResponse rpcResponse;
+ GetLocalShuffleDataResponse getLocalShuffleDataResponse;
+ while (true) {
Review Comment:
I think it will wait less time than using `synchronized`. Better performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
