rickyma commented on code in PR #1616:
URL:
https://github.com/apache/incubator-uniffle/pull/1616#discussion_r1549056839
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -132,12 +132,6 @@ public class ShuffleServerConf extends RssBaseConf {
.withDescription(
"Expired time (ms) for application which has no heartbeat with
coordinator");
- public static final ConfigOption<Integer> SERVER_MEMORY_REQUEST_RETRY_MAX =
Review Comment:
> OK. Do we need to modify the description of client retry config option?
Currently, we don't have descriptions for client retry configs. I think it's
more like internal configs.
And also, our configurations are quite irregular, without a unified format.
Some are defined in File A, some in File B. Some types are ConfigEntry, some
are ConfigOption. Some have descriptions in the README, some only in the Java
files, and some don't even have descriptions in the Java files, like the
current client retry configuration. I feel that we should standardize the
configuration part in the future, fill in the missing information, improve the
README, and so on. I think these series of operations should be completed in a
separate PR. The current PR is only focusing on issue
https://github.com/apache/incubator-uniffle/issues/1606.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
