zuston commented on PR #1610:
URL:
https://github.com/apache/incubator-uniffle/pull/1610#issuecomment-2041367754
> A native code:
>
> ```
> try {
> sendBlocks();
> } catch (Exception e) {
>
> } finally {
> if (block : successBlocks) {
> block.triggerCompleteCallback(); // triggerCompleteCallback to
release data
> }
> if (block: failureBlocks) {
> block.triggerFailureCallback(); // trggerFailureCallback to resend
data if the retry times don't reach the max value. if the failure reaches the
max value, we trigger complete callback. Maybe we should also put fast logic
into this function.
> }
> }
> ```
>
> ```
> BufferManager {
>
> void close() {
> for (block : flightingBlocks) {
> block.triggerCompleteCallback();
> }
> }
> ```
I have introduced the block level completion callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
