zuston commented on PR #1610: URL: https://github.com/apache/incubator-uniffle/pull/1610#issuecomment-2033682096
> After reading the release process, I think we have multiple ways to release the memory. FailureCallback, fast fail and so on. Could you have a common release process for them. Maybe we can release in the method close. For this case, the way of memory release on failure and success is mutually exclusive. That means the close method is not general and abstract to express this. And the close for the event is really weird, although I understand your thought. But this thought may be sensible on the having ownership mechanism of Rust > Another point is whether SuccessCallback is suitable field in the Event. WDYT? It's blockSuccessCallback, rather than eventSuccessCallback. So it's OK for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
