dingshun3016 commented on code in PR #1615:
URL:
https://github.com/apache/incubator-uniffle/pull/1615#discussion_r1555617142
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/ShuffleHandleInfo.java:
##########
@@ -97,21 +105,83 @@ public ShuffleServerInfo
useExistingReassignmentForMultiPartitions(
public ShuffleServerInfo createNewReassignmentForMultiPartitions(
Set<Integer> partitionIds, String faultyServerId, ShuffleServerInfo
replacement) {
if (replacement != null) {
- faultyServerReplacements.put(faultyServerId, replacement);
+ faultyServerToReplacements.put(faultyServerId, replacement);
}
- replacement = faultyServerReplacements.get(faultyServerId);
+ replacement = faultyServerToReplacements.get(faultyServerId);
for (Integer partitionId : partitionIds) {
List<ShuffleServerInfo> replicaServers =
partitionToServers.get(partitionId);
for (int i = 0; i < replicaServers.size(); i++) {
if (replicaServers.get(i).getId().equals(faultyServerId)) {
Review Comment:
There a little problem, when reassign server for the second time,
faultyServerId is not in partitionToServers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
