zuston commented on PR #1615: URL: https://github.com/apache/incubator-uniffle/pull/1615#issuecomment-2044278465
> There are some points which I cared: > > 1. Do we support multiple times reassignments? Do we add some tests for this case? Multiple reassignments servers for one partition will be added in the next PR, which will be used by the following cases; 1. reassign servers fails to send blocks and then reassign again for one partition 2. partition is marked as a huge partition, which will be reassign to multiple servers at the first time, and then different tasks using different reassignment partition server by hash. > 2. Do we work with multiple replicas well? This should be more tests. But in this stage, I will make `multiple replicas` and `reassign` exlusive by the extra check, which also will be added in the next PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
