zhengchenyu commented on PR #1630: URL: https://github.com/apache/incubator-uniffle/pull/1630#issuecomment-2045136049
In fact, both prom and json metrics may produce NaN. I'm only describing a situation where the webhook cannot handle NaN when parsing json metrics. We have two way to solve it. (1) When we parse metrics, we handle the special case. This is current PR's method. Then fetch metrics tool need change. (2) We can change NaN to 0. This eliminates the need to modify the code for parsing metrics, but 0 does not mean not a number. (The same goes for inf) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
