zhengchenyu commented on code in PR #1630:
URL: 
https://github.com/apache/incubator-uniffle/pull/1630#discussion_r1557658621


##########
deploy/kubernetes/operator/pkg/webhook/util/util.go:
##########
@@ -163,7 +164,7 @@ type MetricItem struct {
        Name        string   `json:"name"`
        LabelNames  []string `json:"labelNames"`
        LabelValues []string `json:"labelValues"`
-       Value       float32  `json:"value"`
+       Value       interface{}  `json:"value"`

Review Comment:
   Good idea!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to