zhengchenyu commented on code in PR #1630:
URL:
https://github.com/apache/incubator-uniffle/pull/1630#discussion_r1566703650
##########
deploy/kubernetes/operator/pkg/webhook/util/util.go:
##########
@@ -158,12 +159,30 @@ func NeedInspectPod(pod *corev1.Pod) bool {
return false
}
+// JSONFloat is used to parse the float64 which may be NaN
+type JSONFloat float64
+
+// UnmarshalJSON return the parsed JSONFloat
+func (j *JSONFloat) UnmarshalJSON(v []byte) error {
Review Comment:
Hmm, MarshalJSON is not used here. The metric is generated by shuffle
server. Even if I unify the format, the output format of shuffle server is not
affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
