EnricoMi commented on code in PR #1652:
URL:
https://github.com/apache/incubator-uniffle/pull/1652#discussion_r1568859440
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/ShuffleHandleInfo.java:
##########
@@ -180,6 +195,39 @@ public Map<Integer, List<ShuffleServerInfo>>
getPartitionToServers() {
return partitionToServers;
}
+ /**
+ * key: partitionId, value: the servers for multiple replicas.
+ *
+ * <p>Leveraging the partition reassign mechanism, it could support multiple
servers for one
+ * partition replica for huge partition load balance or reassignment
multiple times. But it will
+ * use the different policies.
+ *
+ * <p>For the former, this will use the hash to get one from the candidates.
For the latter, this
+ * will always get the last one that is available for now.
+ */
+ public Map<Integer, List<ShuffleServerInfo>> getLatestAssignmentPlan(long
taskAttemptId) {
Review Comment:
I am just wondering if `Plan` adds any meaning, or whether `Assignment` is
sufficient?
To put it differently, are `Assignment` and `AssignmentPlan` two different
concepts or rather two synonyms?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
