zuston commented on code in PR #1652:
URL:
https://github.com/apache/incubator-uniffle/pull/1652#discussion_r1571717401
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java:
##########
@@ -344,7 +368,7 @@ protected ShuffleBlockInfo createShuffleBlock(int
partitionId, WriterBuffer wb)
compressed.length,
crc32,
compressed,
- partitionToServers.get(partitionId),
+ partitionAssignmentRetrieveFunc.apply(partitionId),
Review Comment:
partitionAssignmentRetrieveFunc is to get the latest server for the block
failures, and for those normal blocks, it also will get the normal server. I
refactor the original code to make the invoking side unify the assignment
getting logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
