qqqttt123 commented on code in PR #1652: URL: https://github.com/apache/incubator-uniffle/pull/1652#discussion_r1577594873
########## client-spark/common/src/main/java/org/apache/spark/shuffle/writer/TaskAttemptAssignment.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.shuffle.writer; + +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; + +import com.google.common.annotations.VisibleForTesting; +import org.apache.spark.shuffle.ShuffleHandleInfo; + +import org.apache.uniffle.common.ShuffleServerInfo; +import org.apache.uniffle.common.exception.RssException; + +/** This class is to get the partition assignment for ShuffleWriter. */ +public class TaskAttemptAssignment { + private ShuffleHandleInfo handle; + private final long taskAttemptId; + private final Set<String> faultyServers; + private Map<Integer, List<ShuffleServerInfo>> latestAssignment; + + public TaskAttemptAssignment(long taskAttemptId, ShuffleHandleInfo shuffleHandleInfo) { + this.taskAttemptId = taskAttemptId; + this.faultyServers = new HashSet<>(); + this.update(shuffleHandleInfo); + } + + public List<ShuffleServerInfo> retrievePartitionAssignment(int partitionId) { + return latestAssignment.get(partitionId); + } + + public boolean isReassigned(String serverId) { + return faultyServers.contains(serverId); + } + + public void update(ShuffleHandleInfo handle) { + if (handle == null) { + throw new RssException("Errors on updating shuffle handle by the empty handleInfo."); + } + this.handle = handle; + this.latestAssignment = handle.getLatestAssignmentByTaskAttemptId(taskAttemptId); Review Comment: Why do we need to getAssignment by taskAttemptId? Is it related to the shuffleId and stage Id? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
