qqqttt123 commented on code in PR #1652:
URL:
https://github.com/apache/incubator-uniffle/pull/1652#discussion_r1577711275
##########
proto/src/main/proto/Rss.proto:
##########
@@ -605,12 +605,13 @@ message RssReassignFaultyShuffleServerRequest{
int32 shuffleId = 1;
repeated int32 partitionIds = 2;
string faultyShuffleServerId = 3;
+ repeated int32 needLoadBalancePartitionIds = 4;
}
message RssReassignFaultyShuffleServerResponse{
StatusCode status = 1;
- ShuffleServerId server = 2;
- string msg = 3;
+ string msg = 2;
+ ShuffleHandleInfo handle = 3;
Review Comment:
Maybe we should return a reassignment instead of `ShuffleHandleInfo` here?
Reassignment can vary. But ShuffleHandleInfo usually is immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
