zuston commented on code in PR #1652:
URL:
https://github.com/apache/incubator-uniffle/pull/1652#discussion_r1577720104
##########
proto/src/main/proto/Rss.proto:
##########
@@ -605,12 +605,13 @@ message RssReassignFaultyShuffleServerRequest{
int32 shuffleId = 1;
repeated int32 partitionIds = 2;
string faultyShuffleServerId = 3;
+ repeated int32 needLoadBalancePartitionIds = 4;
}
message RssReassignFaultyShuffleServerResponse{
StatusCode status = 1;
- ShuffleServerId server = 2;
- string msg = 3;
+ string msg = 2;
+ ShuffleHandleInfo handle = 3;
Review Comment:
This is another point I want to explain. I hope the reassign could return
the latest assignment rather than a replacement server if the reassignment is a
replacement server you said.
If the reassignment is the task owned latest assignment including the latest
partitions -> servers, I think it's good. But I'm not sure is this any
difference with the current latest shuffle handle info which is readonly for
client side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
